Repository navigation
FOUR-34301: ABE Enhancements - #9185
sanjacornelius wants to merge 32 commits into
Conversation
… existing ABE send/click tests
…params are not HTTP 500
FOUR-34335: Add Responder Tracking and Personalized Email Links for Actions by Email
PR SummaryMedium Risk Overview Sending path: Click path: New helpers Reviewed by Cursor Bugbot for commit e1ba7ba. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1ba7ba. Configure here.
|
|
||
| $pending = Cache::pull(self::ABE_CLICK_CACHE_PREFIX . $ticket); | ||
| if (!is_array($pending) || ($pending['abe_uuid'] ?? null) !== $abe->uuid) { | ||
| return null; |
There was a problem hiding this comment.
Ticket cache dropped on UUID mismatch
Medium Severity
pullPendingAbeClickQuery runs Cache::pull before checking that the parked payload's abe_uuid matches the current token. A leftover abe_click_ticket on any other update_variable URL without abe_sig (another ABE email, a legacy unsigned link) deletes the parked query. After Require Login the user then hits the short intended URL with no query, restore fails, and validation returns 422 instead of completing with the signed recipient.
Reviewed by Cursor Bugbot for commit e1ba7ba. Configure here.
|
QA server K8S was successfully deployed https://tenant-1.ci-74d6541c8b.engk8s.processmaker.net |
|
QA server K8S was successfully deployed https://tenant-1.ci-74d6541c8b.engk8s.processmaker.net |
1 similar comment
|
QA server K8S was successfully deployed https://tenant-1.ci-74d6541c8b.engk8s.processmaker.net |
|






Summary
FOUR-34301 introduces optional Track Responder Identity for Actions by Email (ABE), allowing ProcessMaker to identify which recipient responded to an emailed action while preserving backward compatibility. The feature is opt-in through configEmail.trackResponder; existing ABE implementations continue to work unchanged.
Key Enhancements
Responder Tracking
- Email
- User ID
- Group membership
- IP address
- User agent/device details
-
identity_mismatchflag when the logged-in user differs from the signed recipientPerformance & Scalability
abe_email_stagger_seconds.Email Rendering Improvements
Related PRs
story/FOUR-34301story/FOUR-34301sendAsyncdelayHow to test
Legacy (default)
abe_responder.Track responder
abe_responderwith signedemail/user_id/groups.identity_mismatchtrue when applicable.Require Login + tracking
abe_click_ticket).Staggering (full stack)
SendEmailjobs with incremental delays whenabe_email_stagger_seconds> 0 (requires updated package-actions-by-email).Connector email UI
Automated
AbeResponderTest,TaskActionByEmailSelfServiceTest,AbeLargeRecipientGroupTest,TaskActionByEmailLinkRewriteTest,TaskControllerABE tests as applicable.ci:connector-send-email:story/FOUR-34301
ci:package-actions-by-email:story/FOUR-34301
ci:deploy
Code Review Checklist